feat(player): Make 'searchForTrackSelect_' private & use 'el' as parameter in function 'getIsFocusable' #8697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter in function 'getIsFocusable'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8697 +/- ##
=======================================
Coverage 83.00% 83.00%
=======================================
Files 120 120
Lines 7995 7996 +1
Branches 1925 1926 +1
=======================================
+ Hits 6636 6637 +1
Misses 1359 1359 ☔ View full report in Codecov by Sentry. |
wseymour15
approved these changes
Apr 18, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor update related to the 'spatial navigation' feature to make 'searchForTrackSelect_' private & use 'el' as parameter in function 'getIsFocusable', since in some cases there can be an issue only using 'this.el_' when the function is called.w
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist